DanielCarter-stack commented on issue #10590: URL: https://github.com/apache/seatunnel/issues/10590#issuecomment-4039699605
<!-- code-pr-reviewer --> Thanks for the detailed analysis. This appears to be a valid bug. Based on the evidence: - `ConfigShadeUtils.decryptConfig()` exists at `seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java` - CLI mode correctly calls decryption (via `ConfDecryptCommand`) - JSON format works through `RestUtil.buildConfig()` → `ConfigBuilder.of()` - HOCON/SQL branches in `JobInfoService.submitJob()` and `SubmitJobByUploadFileServlet` likely bypass decryption **Suggested fix:** 1. In `JobInfoService.submitJob()`: call `ConfigShadeUtils.decryptConfig(config)` after parsing for both HOCON and SQL branches 2. In `SubmitJobByUploadFileServlet`: add the same decryption call for all formats 3. Add unit tests covering HOCON/SQL decryption scenarios Your test config with `shade.identifier = "base64"` in the `env` section is correct. A PR is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
