yzeng1618 commented on code in PR #10506:
URL: https://github.com/apache/seatunnel/pull/10506#discussion_r2887359923
##########
seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java:
##########
@@ -480,6 +486,200 @@ public void testClearCoordinatorService() {
.count());
}
+ @Test
+ void testUpdateTaskExecutionStateWaitsForRestoreCompletion() throws
Exception {
Review Comment:
update the test method name to reflect the actual behavior，refer to
testUpdateTaskExecutionStateRetriesUntilRestoreComplete
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -461,6 +462,17 @@ private void notifyTaskStatusToMaster(
} catch (JobNotFoundException e) {
logger.warning("send notify task status failed because can't
find job", e);
notifyStateSuccess = true;
+ } catch (JobRestoreInProgressException e) {
+ logger.info(ExceptionUtils.getMessage(e));
+ logger.info(
+ String.format(
+ "notify the job of the task(%s) status failed,
retry in %s millis",
+ taskGroupLocation, sleepTime));
+ try {
+ Thread.sleep(sleepTime);
+ } catch (InterruptedException ex) {
+ logger.severe(e);
Review Comment:
It is recommended to change it to ex and invoke
Thread.currentThread().interrupt() to restore the interrupt flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
