Hisoka-X commented on code in PR #9673:
URL: https://github.com/apache/seatunnel/pull/9673#discussion_r2312721358
##########
docs/en/transform-v2/embedding.md:
##########
@@ -263,6 +319,165 @@ sink {
}
```
+### Multimodal Embedding (Volcengine Doubao)
Review Comment:
Could you add an example for binary file mode?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/reader/BinaryReadStrategyTest.java:
##########
@@ -70,7 +70,9 @@ public void testBinaryReadWithDefaultChunkSize() throws
IOException {
List<SeaTunnelRow> rows = collector.getRows();
Assertions.assertEquals(
- 2, rows.size(), "Should have 2 chunks for 2048 bytes with
default 1024 chunk size");
+ 2 + 1,
+ rows.size(),
+ "Should have 2 chunks for 2048 bytes with default 1024 chunk
size");
Review Comment:
```suggestion
"Should have 3 chunks for 2048 bytes with default 1024 chunk
size");
```
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/reader/BinaryReadStrategyTest.java:
##########
@@ -128,7 +130,7 @@ public void testBinaryReadCompleteFileMode() throws
IOException {
binaryReadStrategy.read(testFile.getAbsolutePath(), "test_table",
collector);
List<SeaTunnelRow> rows = collector.getRows();
- Assertions.assertEquals(1, rows.size(), "Should have 1 row in complete
file mode");
+ Assertions.assertEquals(1 + 1, rows.size(), "Should have 1 row in
complete file mode");
Review Comment:
```suggestion
Assertions.assertEquals(1 + 1, rows.size(), "Should have 2 row in
complete file mode");
```
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/reader/BinaryReadStrategyTest.java:
##########
@@ -102,7 +104,7 @@ public void testBinaryReadWithCustomChunkSize() throws
IOException {
List<SeaTunnelRow> rows = collector.getRows();
Assertions.assertEquals(
- 3, rows.size(), "Should have 3 chunks for 1500 bytes with 512
chunk size");
+ 3 + 1, rows.size(), "Should have 3 chunks for 1500 bytes with
512 chunk size");
Review Comment:
```suggestion
3 + 1, rows.size(), "Should have 4 chunks for 1500 bytes
with 512 chunk size");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
