dybyte commented on code in PR #9696:
URL: https://github.com/apache/seatunnel/pull/9696#discussion_r2270580615


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -623,6 +629,18 @@ private void removeJobIMap() {
                                                 
runningJobStateTimestampsIMap.remove(
                                                         
task.getTaskGroupLocation());
                                             });
+
+                            String checkpointStateImapKey =
+                                    
CheckpointCoordinator.getCheckpointStateImapKey(

Review Comment:
   ```java
   String checkpointStateImapKey = 
checkpointManager.getCheckpointCoordinator(pipeline.getPipelineId()).getCheckpointStateImapKey();
   ```
   Is this the approach you were referring to?
   However, since `getCheckpointCoordinator()` method is annotated with 
`@VisibleForTesting`, I think it's better to avoid using it in production code.
   Please let me know if I misunderstood anything. Thanks!
   
   
[checkpointManager.getCheckpointCoordinator()](https://github.com/apache/seatunnel/blob/085023ad0db1a8729ce724a14855c0077f051dfe/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointManager.java#L179)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to