Copilot commented on code in PR #9593:
URL: https://github.com/apache/seatunnel/pull/9593#discussion_r2227187741
##########
seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/source/TDengineSource.java:
##########
@@ -59,8 +60,7 @@
*/
public class TDengineSource
implements SeaTunnelSource<SeaTunnelRow, TDengineSourceSplit,
TDengineSourceState> {
-
- private final StableMetadata stableMetadata;
+ @Getter private final StableMetadata stableMetadata;
private final TDengineSourceConfig tdengineSourceConfig;
private final CatalogTable catalogTable;
Review Comment:
[nitpick] The @Getter annotation exposes internal metadata that was
previously private. Consider if this field needs to be public or if a more
specific accessor method would be better for encapsulation.
```suggestion
private final StableMetadata stableMetadata;
private final TDengineSourceConfig tdengineSourceConfig;
private final CatalogTable catalogTable;
public StableMetadata getStableMetadata() {
return stableMetadata;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
