Copilot commented on code in PR #9612:
URL: https://github.com/apache/seatunnel/pull/9612#discussion_r2224626865
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/fake_cdc_to_dynamic_bucket_paimon_case.conf:
##########
@@ -120,12 +120,12 @@ transform {
sink {
Paimon {
- warehouse = "file:///tmp/paimon"
+ warehouse = "file:///tmp/seatunnel_mnt/paimon"
database = "default"
Review Comment:
The table name change from 'st_test_3' to 'st_test_cdc_write' appears
unrelated to the volume mounting optimization and should be documented or moved
to a separate change.
```suggestion
database = "default"
# The table name was changed from 'st_test_3' to 'st_test_cdc_write' to
align with the new configuration requirements.
```
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/fake_to_paimon_with_full_type.conf:
##########
@@ -85,7 +85,8 @@ source {
sink {
Paimon {
Review Comment:
The addition of plugin_input configuration appears unrelated to the volume
mounting optimization. This should be documented or moved to a separate change.
```suggestion
Paimon {
# Specifies the input plugin for the sink. This is required for the sink
to process data from the source.
```
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java:
##########
@@ -43,6 +43,21 @@ public abstract class AbstractTestContainer implements
TestContainer {
protected static final String START_ROOT_MODULE_NAME = "seatunnel-core";
public static final String SEATUNNEL_HOME = "/tmp/seatunnel/";
+
+ protected static final boolean isWindows =
+
System.getProperties().getProperty("os.name").toUpperCase().contains("WINDOWS");
+
+ protected static String hostName = System.getProperty("user.name");
+ protected Integer hostUid = Integer.parseInt(System.getProperty("user.id",
"1000"));
+ protected Integer hostGid =
Integer.parseInt(System.getProperty("user.gid", "1000"));
+
Review Comment:
The hostUid and hostGid variables are declared but not used in the visible
code. Consider removing them if they're not needed for the volume mounting
implementation.
```suggestion
```
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/fake_to_dynamic_bucket_paimon_case6.conf:
##########
@@ -60,7 +60,7 @@ source {
}
{
kind = INSERT
- fields = [{"a": "f"}, [104], null, false, 118, 15988, 563873951,
7084913402530365004, 1.24, 1.234, "2924137191386439303744.39292214",
"bWlJWmo=", "2023-04-24", "2023-04-24T23:20:58", "23:20:58"]
+ fields = [{"a": "f"}, [104], "", false, 118, 15988, 563873951,
7084913402530365004, 1.24, 1.234, "2924137191386439303744.39292214",
"bWlJWmo=", "2023-04-24", "2023-04-24T23:20:58", "23:20:58"]
Review Comment:
The change from 'null' to empty string ("") in the test data appears
unrelated to the volume mounting optimization and should be documented or moved
to a separate change.
```suggestion
fields = [{"a": "f"}, [104], null, false, 118, 15988, 563873951,
7084913402530365004, 1.24, 1.234, "2924137191386439303744.39292214",
"bWlJWmo=", "2023-04-24", "2023-04-24T23:20:58", "23:20:58"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
