Hisoka-X commented on code in PR #9590:
URL: https://github.com/apache/seatunnel/pull/9590#discussion_r2215197852
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/psql/PostgresJdbcRowConverter.java:
##########
@@ -189,6 +190,11 @@ public PreparedStatement toExternal(
inetObject.setType(PG_INET);
inetObject.setValue(String.valueOf(row.getField(fieldIndex)));
statement.setObject(statementIndex, inetObject);
+ } else if (INTERVAL.equalsIgnoreCase(sourceType)) {
+ PGobject inetObject = new PGobject();
+ inetObject.setType(INTERVAL);
+
inetObject.setValue(String.valueOf(row.getField(fieldIndex)));
+ statement.setObject(statementIndex, inetObject);
Review Comment:
This part didn't cover by test case. Please update postgres e2e test case.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/psql/PostgresJdbcRowConverter.java:
##########
@@ -49,6 +49,7 @@
import java.util.Locale;
import java.util.Optional;
+import static com.teradata.jdbc.jdbc_4.ifsupport.EscapeConstants.INTERVAL;
Review Comment:
The import class seems not right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
