Hisoka-X commented on code in PR #9558:
URL: https://github.com/apache/seatunnel/pull/9558#discussion_r2207313509
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/exception/PaimonConnectorErrorCode.java:
##########
@@ -29,7 +29,7 @@ public enum PaimonConnectorErrorCode implements
SeaTunnelErrorCode {
LOAD_CATALOG("PAIMON-06", "Load catalog failed"),
GET_FILED_FAILED("PAIMON-07", "Get field failed"),
UNSUPPORTED_PRIMARY_DATATYPE("PAIMON-08", "Paimon primary key datatype is
unsupported"),
- WRITE_PROPS_BUCKET_KEY_ERROR("PAIMON-09", "Cannot define 'bucket-key' in
dynamic bucket mode"),
+ WRITE_PROPS_BUCKET_KEY_ERROR("API-03", "Cannot define 'bucket-key' in
dynamic bucket mode"),
Review Comment:
why change this?
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java:
##########
@@ -104,7 +106,12 @@ public String getDefaultDatabase() throws CatalogException
{
@Override
public boolean databaseExists(String databaseName) throws CatalogException
{
- return catalog.databaseExists(databaseName);
+ try {
+ Database database = catalog.getDatabase(databaseName);
+ return Objects.nonNull(database);
+ } catch (org.apache.paimon.catalog.Catalog.DatabaseNotExistException
e) {
Review Comment:
you can import org.apache.paimon.catalog.Catalog.DatabaseNotExistException
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java:
##########
@@ -219,7 +231,14 @@ private Schema buildPaimonSchema(@NonNull
org.apache.paimon.schema.TableSchema s
Schema.Builder builder = Schema.newBuilder();
schema.fields()
.forEach(field -> builder.column(field.name(), field.type(),
field.description()));
- builder.options(schema.options());
+ Map<String, String> map = new HashMap<>();
+ schema.options()
+ .forEach(
+ (x, y) -> {
+ map.put(x, y);
+ });
+ map.remove("path");
Review Comment:
Any reason for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
