prclin commented on PR #9471:
URL: https://github.com/apache/seatunnel/pull/9471#issuecomment-3006832169

   > > > Hi @prclin . Could you share your starrocks version? Does it not 
support `DECIMALV3`? I found this type is supported by new starrocks version. 
https://docs.starrocks.io/docs/sql-reference/data-types/numeric/DECIMAL/
   > > 
   > > 
   > > my version is 3.3;
   > > yes it does support decimalv3,but all version of type definition is 
DECIMAL, what ever DECIMALV2, DECIMALV3, it all present by column type 
DECIMAL;which determine the version is the precision. it doesn`t need the 
explict version.
   > 
   > So explicitly specifying decimalv3 should not result in an error, right? 
I'm curious as to why it results in an error.
   
   no; such as the offical example:
   ```sql
   CREATE TABLE decimalDemo (
       pk BIGINT(20) NOT NULL COMMENT "",
       account DECIMAL(20,10) COMMENT ""
   ) ENGINE=OLAP 
   DUPLICATE KEY(pk)
   COMMENT "OLAP"
   DISTRIBUTED BY HASH(pk);
   ```
   thisi is ok, the decimal will be decimal v2, because precision is in [1,27];
   
   and DECIMALV3 is not a keyword of starrocks, you will see here 
https://docs.starrocks.io/docs/sql-reference/sql-statements/keywords/#d
   
   
   starrocks has these decimal keywords:
   DECIMAL
   DECIMALV2
   DECIMAL32
   DECIMAL64
   DECIMAL128
   
   and DECIMAL can replace other decimalX keywords。
   
   so we can only use DECIMAL , which will determine whether the final storage 
type is DECIMALV2 or DECIMAL64 or DECIMAL128 based on accuracy and scale.
   
   expicitly specifying DECIMALV2、DECIMAL64 or DECIMAL128, only check if the 
corresponding precision and scale match.
   if use `DECIMAL64(20,1)` will case error `[42000][1064] DECIMAL's precision 
should range from 1 to 18`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to