Copilot commented on code in PR #9496:
URL: https://github.com/apache/seatunnel/pull/9496#discussion_r2165530582
##########
seatunnel-connectors-v2/connector-hudi/src/main/java/org/apache/seatunnel/connectors/seatunnel/hudi/catalog/HudiCatalog.java:
##########
@@ -233,6 +234,7 @@ public void createTable(TablePath tablePath, CatalogTable
table, boolean ignoreI
.setPayloadClassName(HoodieAvroPayload.class.getName())
.setCDCEnabled(
Boolean.parseBoolean(table.getOptions().get(CDC_ENABLED.key())))
+
.setPreCombineField(table.getOptions().get(PRECOMBINE_FIELD.key()))
Review Comment:
[nitpick] If the 'precombine_field' is optional, consider adding a null
check before calling setPreCombineField to avoid potential issues if no value
is provided.
```suggestion
.setPreCombineField(
table.getOptions().get(PRECOMBINE_FIELD.key()) != null
?
table.getOptions().get(PRECOMBINE_FIELD.key())
: null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
