yzeng1618 opened a new pull request, #9460:
URL: https://github.com/apache/seatunnel/pull/9460
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
This PR fixes a timezone issue in the Iceberg connector when converting
LocalDateTime to OffsetDateTime. Previously, LocalDateTime values were directly
converted to UTC timezone without considering the system's local timezone,
which could lead to incorrect timestamp values in Iceberg tables. This PR
ensures that LocalDateTime values are properly interpreted in the system's
timezone before being converted to UTC, preserving the correct instant in time.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
Yes, this PR introduces a user-facing change in how timestamps are handled
when writing data to Iceberg tables. Previously, LocalDateTime values were
directly converted to UTC without considering the system timezone, which could
result in incorrect timestamp values. After this change, LocalDateTime values
will be correctly interpreted in the system's timezone before being converted
to UTC, ensuring that the same instant in time is preserved. This change
affects users who are writing timestamp data to Iceberg tables using the
SeaTunnel Iceberg connector.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
This patch was tested by adding a comprehensive test class
RowConverterTest.java that verifies various data type conversions, with special
focus on timestamp handling. The test includes:
A basic test that verifies conversion of all supported data types
A specific test for timestamp with timezone conversion that:
Creates a LocalDateTime instance
Converts it using the RowConverter
Verifies that the conversion correctly interprets the timestamp in the
system timezone before converting to UTC
Compares the result with a manually calculated expected value
The test ensures that the same instant in time is preserved when converting
from LocalDateTime to OffsetDateTime, regardless of the system's timezone
settings.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
