sohurdc commented on code in PR #9427:
URL: https://github.com/apache/seatunnel/pull/9427#discussion_r2152451400
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -627,7 +629,11 @@ private void updateMetricsContextInImap() {
boolean unLockedIMap = false;
while (!unLockedIMap) {
try {
-
metricsImap.unlock(Constant.IMAP_RUNNING_JOB_METRICS_KEY);
+ if (System.currentTimeMillis() - lockTs > 5000) {
+ logger.severe("unlock imap: " +
Constant.IMAP_RUNNING_JOB_METRICS_KEY + " exceeds 5s, exit while loop.");
+ } else {
+
metricsImap.unlock(Constant.IMAP_RUNNING_JOB_METRICS_KEY);
Review Comment:
Sorry, I am not very familiar with the Hazelcast framework and I am not sure
about the difference between forceUnlock and unlock. If I change to
forceUnlock, do I still need a while loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
