Copilot commented on code in PR #9373:
URL: https://github.com/apache/seatunnel/pull/9373#discussion_r2113051132
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverter.java:
##########
@@ -107,13 +108,19 @@ public class MySqlTypeConverter implements
TypeConverter<BasicTypeDefine<MysqlTy
new MySqlTypeConverter(MySqlVersion.V_5_7);
private final MySqlVersion version;
+ private final boolean intTypeNarrowing;
+
+ public MySqlTypeConverter() {
Review Comment:
[nitpick] The constructors for `MySqlTypeConverter` (no-arg, single-arg,
two-arg) are interleaved; grouping and ordering them together can improve
readability.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -108,6 +108,13 @@ public interface JdbcOptions {
.withDescription(
"decimal type narrowing, if true, the decimal type
will be narrowed to the int or long type if without loss of precision. Only
support for Oracle at now.");
+ Option<Boolean> INT_TYPE_NARROWING =
Review Comment:
[nitpick] Consider rephrasing the description to "Currently supported for
MySQL only." to improve clarity and correct grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
