Hisoka-X commented on code in PR #9285:
URL: https://github.com/apache/seatunnel/pull/9285#discussion_r2080837111
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/source/MySqlDialect.java:
##########
@@ -121,7 +120,8 @@ public FetchTask<SourceSplitBase>
createFetchTask(SourceSplitBase sourceSplitBas
if (sourceSplitBase.isSnapshotSplit()) {
return new
MySqlSnapshotFetchTask(sourceSplitBase.asSnapshotSplit());
} else {
- return new
MySqlBinlogFetchTask(sourceSplitBase.asIncrementalSplit());
+ return new
org.apache.seatunnel.connectors.seatunnel.cdc.mysql.source.reader.fetch
+
.binlog.MySqlBinlogSplitReader(sourceSplitBase.asIncrementalSplit());
Review Comment:
why change this?
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/source/MySqlIncrementalSource.java:
##########
@@ -78,6 +85,92 @@ public String getPluginName() {
return IDENTIFIER;
}
+ @Override
+ protected StartupConfig getStartupConfig(ReadonlyConfig config) {
+ StartupMode startupMode = config.get(getStartupModeOption());
+
+ if (startupMode == StartupMode.TIMESTAMP) {
+ long timestamp;
+ String sourceDescription;
+
+ // 优先使用SourceOptions.STARTUP_TIMESTAMP
Review Comment:
please do not use chinese
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
