Hisoka-X commented on code in PR #9281:
URL: https://github.com/apache/seatunnel/pull/9281#discussion_r2076660807
##########
seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java:
##########
@@ -281,10 +281,16 @@ private HazelcastInstance createServerInLocal(
// set the default async executor for Hazelcast InvocationFuture
ConcurrencyUtil.setDefaultAsyncExecutor(CompletableFuture.EXECUTOR);
- return HazelcastInstanceFactory.newHazelcastInstance(
- seaTunnelConfig.getHazelcastConfig(),
- Thread.currentThread().getName(),
- new SeaTunnelNodeContext(seaTunnelConfig));
+ try {
+ return HazelcastInstanceFactory.newHazelcastInstance(
+ seaTunnelConfig.getHazelcastConfig(),
+ Thread.currentThread().getName(),
+ new SeaTunnelNodeContext(seaTunnelConfig));
Review Comment:
create hazelcast instance is one of potential crisis. So we should handle it
in
https://github.com/apache/seatunnel/blob/0b1122ceda60b4e94a9c2665e33f0d893644b22d/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/SeaTunnel.java#L40
to catch all exist problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
