Copilot commented on code in PR #9277:
URL: https://github.com/apache/seatunnel/pull/9277#discussion_r2076602077
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/util/ClickhouseUtil.java:
##########
@@ -41,7 +41,7 @@ public static List<ClickHouseNode> createNodes(ReadonlyConfig
config) {
config.get(ClickhouseBaseOptions.SERVER_TIME_ZONE),
config.get(ClickhouseBaseOptions.USERNAME),
config.get(ClickhouseBaseOptions.PASSWORD),
Review Comment:
[nitpick] Consider adding an inline comment explaining the role and expected
structure of CLICKHOUSE_CONFIG during node initialization to aid future
maintainability.
```suggestion
config.get(ClickhouseBaseOptions.PASSWORD),
// CLICKHOUSE_CONFIG is a map of configuration options for
the ClickHouse client.
// Keys and values represent specific settings supported by
the ClickHouse client library.
```
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkFactory.java:
##########
@@ -95,7 +96,7 @@ public TableSink createSink(TableSinkFactoryContext context) {
readonlyConfig.get(SERVER_TIME_ZONE),
readonlyConfig.get(USERNAME),
readonlyConfig.get(PASSWORD),
- null);
+ readonlyConfig.get(CLICKHOUSE_CONFIG));
Review Comment:
[nitpick] Consider adding a comment to describe the purpose of passing
CLICKHOUSE_CONFIG in the sink setup, providing clarity for contributors
reviewing configuration handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
