Hisoka-X commented on code in PR #9138: URL: https://github.com/apache/seatunnel/pull/9138#discussion_r2041321995
########## seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpPaginationType.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seatunnel.connectors.seatunnel.http.config; + +public enum HttpPaginationType { + /** Page number based pagination */ + PAGE_NUMBER_PAGINATION( + "PageNumberPagination", + "traditional page-number-based pagination,uses a page number and page size to retrieve a specific slice of data"), + /** Cursor based pagination */ + CURSOR_PAGINATION( + "CursorPagination", + "token-based cursor pagination,uses a cursor/token to fetch the next set of data based on a specific point or marker"); Review Comment: ```suggestion PAGE_NUMBER( "PageNumberPagination", "traditional page-number-based pagination,uses a page number and page size to retrieve a specific slice of data"), /** Cursor based pagination */ CURSOR( "CursorPagination", "token-based cursor pagination,uses a cursor/token to fetch the next set of data based on a specific point or marker"); ``` ########## docs/en/connector-v2/source/Http.md: ########## @@ -393,6 +404,42 @@ source { } +``` + +#### 2. CursorPagination +the `pageing.page_type` parameter must be set to `CursorPagination`. +`cursor_field` is the field name of the cursor in the request parameters. Review Comment: ```suggestion `cursor_field` is the field name of the cursor in the request parameters. ``` ########## seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java: ########## @@ -149,26 +150,64 @@ public void pollAndCollectData(Collector<SeaTunnelRow> output) throws Exception } private void updateRequestParam(PageInfo pageInfo) { + // 1. keep page param as http param + // keep page param as http param Review Comment: ```suggestion // 1. keep page param as http param ``` ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/resources/http_page_cursor_num_assert.conf: ########## @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +env { + parallelism = 1 + job.mode = "BATCH" +} + +source { + Http { + plugin_output = "http" + url = "http://mockserver:1080/query/cursor_pages?cursor=cursor_1"; Review Comment: we should add ``` params={ cursor: "${cursor}" } ``` into config. Otherwise the request always with cursor_1. ```suggestion url = "http://mockserver:1080/query/cursor_pages"; ``` ########## docs/en/connector-v2/source/Http.md: ########## @@ -393,6 +404,42 @@ source { } +``` + +#### 2. CursorPagination +the `pageing.page_type` parameter must be set to `CursorPagination`. +`cursor_field` is the field name of the cursor in the request parameters. +`cursor_response_field` is the field name of the cursor field in the response data, this value is then passed as the value of the `cursor_field` parameter in the next request. +````hocon + +source { Review Comment: we should add this https://github.com/apache/seatunnel/pull/9138/files#diff-31bd0672f7a316bde3b591f194484526bed84f71b007370b75c2c2bf99223fb4R386-R388 to add pageing fields into request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
