SEZ9 commented on code in PR #9120: URL: https://github.com/apache/seatunnel/pull/9120#discussion_r2032549143
########## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/nlpmodel/embedding/EmbeddingTransformFactory.java: ########## @@ -48,6 +48,14 @@ public OptionRule optionRule() { EmbeddingTransformConfig.API_PATH, EmbeddingTransformConfig.SINGLE_VECTORIZED_INPUT_NUMBER, EmbeddingTransformConfig.PROCESS_BATCH_SIZE) + .conditional( + EmbeddingTransformConfig.MODEL_PROVIDER, + ModelProvider.AMAZON, + EmbeddingTransformConfig.API_KEY, + EmbeddingTransformConfig.SECRET_KEY, + EmbeddingTransformConfig.AWS_REGION, + EmbeddingTransformConfig.MODEL, + EmbeddingTransformConfig.DIMENSION) Review Comment: AWS region is a required parameter when calling the Amazon model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org