litiliu commented on code in PR #9095: URL: https://github.com/apache/seatunnel/pull/9095#discussion_r2030586824
##########
docs/en/connector-v2/source/Iceberg.md:
##########
@@ -90,8 +90,10 @@ libfb303-xxx.jar
| use_snapshot_id | long | no | - |
Instructs this scan to look for use the given snapshot ID.
|
| use_snapshot_timestamp | long | no | - |
Instructs this scan to look for use the most recent snapshot as of the given
time in milliseconds. timestamp – the timestamp in millis since the Unix epoch
|
| stream_scan_strategy | enum | no | FROM_LATEST_SNAPSHOT |
Starting strategy for stream mode execution, Default to use
`FROM_LATEST_SNAPSHOT` if don’t specify any value,The optional values
are:<br/>TABLE_SCAN_THEN_INCREMENTAL: Do a regular table scan then switch to
the incremental mode.<br/>FROM_LATEST_SNAPSHOT: Start incremental mode from the
latest snapshot inclusive.<br/>FROM_EARLIEST_SNAPSHOT: Start incremental mode
from the earliest snapshot inclusive.<br/>FROM_SNAPSHOT_ID: Start incremental
mode from a snapshot with a specific id inclusive.<br/>FROM_SNAPSHOT_TIMESTAMP:
Start incremental mode from a snapshot with a specific timestamp inclusive. |
-| increment.scan-interval | long | no | 2000 | The
interval of increment scan(mills)
|
-| common-options | | no | - |
Source plugin common parameters, please refer to [Source Common
Options](../source-common-options.md) for details.
|
+| increment.scan-interval | long | no | 2000 | The
interval of increment scan(mills)
|
+| common-options | | no | - |
Source plugin common parameters, please refer to [Source Common
Options](../source-common-options.md) for details.
|
+| filter | String | no | - | The
where clause to filter the iceberg data. It mustn't contain the table name. For
example: There is an iceberg table contains an `id` column with the `int` type,
now we want to filter the data that `id`>100. Then you can input `id > 100`.
|
Review Comment:
updated the `parseWhereClauseToIcebergExpression` method, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
