Hisoka-X commented on code in PR #8993:
URL: https://github.com/apache/seatunnel/pull/8993#discussion_r2000002596
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -744,6 +751,11 @@ public PassiveCompletableFuture<Void> cancelJob(long
jobId) {
future.complete(null);
return new PassiveCompletableFuture<>(future);
} else {
+ // Cancel pending tasks
+ if (pendingJobMasterMap.containsKey(jobId)) {
+ pendingJobMasterMap.remove(jobId);
+ logger.warning(String.format("Cancel pending tasks : %s",
jobId));
Review Comment:
```suggestion
logger.debug(String.format("Cancel pending tasks : %s",
jobId));
```
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -248,12 +248,19 @@ private void pendingJobSchedule() throws
InterruptedException {
Thread.sleep(3000);
return;
}
+
+ Long jobId = jobMaster.getJobId();
+
+ if (!pendingJobMasterMap.containsKey(jobId)) {
+ logger.warning(String.format("Job ID : %s already cancelled",
jobId));
Review Comment:
```suggestion
logger.debug(String.format("Job ID : %s already cancelled",
jobId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
