hailin0 commented on code in PR #9010:
URL: https://github.com/apache/seatunnel/pull/9010#discussion_r2007349709
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -193,6 +193,48 @@ public static class MasterServerConfigOptions {
.defaultValue(false)
.withDescription("Whether to enable the http server.");
+ public static final Option<Boolean> ENABLE_HTTPS =
+ Options.key("enable-https")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether to enable the https
server.");
+
+ public static final Option<Integer> HTTPS_PORT =
+ Options.key("port")
+ .intType()
+ .defaultValue(8443)
+ .withDescription("The port of the https server.");
+
+ public static final Option<String> KEY_STORE_PATH =
+ Options.key("key-store-path")
+ .stringType()
+ .defaultValue("")
Review Comment:
```suggestion
.NoDefaultValue()
```
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -193,6 +193,48 @@ public static class MasterServerConfigOptions {
.defaultValue(false)
.withDescription("Whether to enable the http server.");
+ public static final Option<Boolean> ENABLE_HTTPS =
+ Options.key("enable-https")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether to enable the https
server.");
+
+ public static final Option<Integer> HTTPS_PORT =
+ Options.key("port")
+ .intType()
+ .defaultValue(8443)
+ .withDescription("The port of the https server.");
+
+ public static final Option<String> KEY_STORE_PATH =
+ Options.key("key-store-path")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store path of the https
server.");
+
+ public static final Option<String> KEY_STORE_PASSWORD =
+ Options.key("key-store-password")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store password of the https
server.");
+
+ public static final Option<String> KEY_MANAGER_PASSWORD =
+ Options.key("key-manager-password")
+ .stringType()
+ .defaultValue("")
Review Comment:
```suggestion
.noDefaultValue()
```
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -193,6 +193,48 @@ public static class MasterServerConfigOptions {
.defaultValue(false)
.withDescription("Whether to enable the http server.");
+ public static final Option<Boolean> ENABLE_HTTPS =
+ Options.key("enable-https")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether to enable the https
server.");
+
+ public static final Option<Integer> HTTPS_PORT =
+ Options.key("port")
+ .intType()
+ .defaultValue(8443)
+ .withDescription("The port of the https server.");
+
+ public static final Option<String> KEY_STORE_PATH =
+ Options.key("key-store-path")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store path of the https
server.");
+
+ public static final Option<String> KEY_STORE_PASSWORD =
+ Options.key("key-store-password")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store password of the https
server.");
+
+ public static final Option<String> KEY_MANAGER_PASSWORD =
+ Options.key("key-manager-password")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key manager password of the
https server.");
+
+ public static final Option<String> TRUST_STORE_PATH =
+ Options.key("trust-store-path")
+ .stringType()
+ .defaultValue("")
Review Comment:
```suggestion
.noDefaultValue()
```
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -193,6 +193,48 @@ public static class MasterServerConfigOptions {
.defaultValue(false)
.withDescription("Whether to enable the http server.");
+ public static final Option<Boolean> ENABLE_HTTPS =
+ Options.key("enable-https")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether to enable the https
server.");
+
+ public static final Option<Integer> HTTPS_PORT =
+ Options.key("port")
+ .intType()
+ .defaultValue(8443)
+ .withDescription("The port of the https server.");
+
+ public static final Option<String> KEY_STORE_PATH =
+ Options.key("key-store-path")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store path of the https
server.");
+
+ public static final Option<String> KEY_STORE_PASSWORD =
+ Options.key("key-store-password")
+ .stringType()
+ .defaultValue("")
Review Comment:
```suggestion
.noDefaultValue()
```
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java:
##########
@@ -193,6 +193,48 @@ public static class MasterServerConfigOptions {
.defaultValue(false)
.withDescription("Whether to enable the http server.");
+ public static final Option<Boolean> ENABLE_HTTPS =
+ Options.key("enable-https")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether to enable the https
server.");
+
+ public static final Option<Integer> HTTPS_PORT =
+ Options.key("port")
+ .intType()
+ .defaultValue(8443)
+ .withDescription("The port of the https server.");
+
+ public static final Option<String> KEY_STORE_PATH =
+ Options.key("key-store-path")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store path of the https
server.");
+
+ public static final Option<String> KEY_STORE_PASSWORD =
+ Options.key("key-store-password")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key store password of the https
server.");
+
+ public static final Option<String> KEY_MANAGER_PASSWORD =
+ Options.key("key-manager-password")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The key manager password of the
https server.");
+
+ public static final Option<String> TRUST_STORE_PATH =
+ Options.key("trust-store-path")
+ .stringType()
+ .defaultValue("")
+ .withDescription("The trust store path of the https
server.");
+
+ public static final Option<String> TRUST_STORE_PASSWORD =
+ Options.key("trust-store-password")
+ .stringType()
+ .defaultValue("")
Review Comment:
```suggestion
.noDefaultValue()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
