Hisoka-X commented on code in PR #9052:
URL: https://github.com/apache/seatunnel/pull/9052#discussion_r2013726130
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -132,6 +133,9 @@ private int getBytesForValue(Object v, SeaTunnelDataType<?>
dataType) {
SqlType sqlType = dataType.getSqlType();
switch (sqlType) {
case STRING:
+ if (v instanceof BigDecimal) {
+ return v.toString().length();
+ }
Review Comment:
If it is declared as string, but the returned type is BigDecimal, this is
wrong. We need to solve this wrong behavior instead of condoning it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
