hailin0 commented on code in PR #9028:
URL: https://github.com/apache/seatunnel/pull/9028#discussion_r2009393140
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -237,7 +237,11 @@ default String getRowExistsStatement(
* @return the dialects {@code UPSERT} statement or {@link
Optional#empty()}.
*/
Optional<String> getUpsertStatement(
- String database, String tableName, String[] fieldNames, String[]
uniqueKeyFields);
+ String database,
+ String tableName,
+ String[] fieldNames,
+ String[] primaryKeyFields,
+ String[] uniqueKeyFields);
Review Comment:
Why not merge `primaryKeyFields` into `uniqueKeyFields`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
