jinkachy commented on code in PR #9002:
URL: https://github.com/apache/seatunnel/pull/9002#discussion_r2004838229


##########
docs/en/connector-v2/source/Jdbc.md:
##########
@@ -68,6 +68,8 @@ supports query SQL and can achieve projection effect.
 | split.sample-sharding.threshold            | Int     | No       | 1000       
     | This configuration specifies the threshold of estimated shard count to 
trigger the sample sharding strategy. When the distribution factor is outside 
the bounds specified by `chunk-key.even-distribution.factor.upper-bound` and 
`chunk-key.even-distribution.factor.lower-bound`, and the estimated shard count 
(calculated as approximate row count / chunk size) exceeds this threshold, the 
sample sharding strategy will be used. This can help to handle large datasets 
more efficiently. The default value is 1000 shards.                             
                                                                                
    |
 | split.inverse-sampling.rate                | Int     | No       | 1000       
     | The inverse of the sampling rate used in the sample sharding strategy. 
For example, if this value is set to 1000, it means a 1/1000 sampling rate is 
applied during the sampling process. This option provides flexibility in 
controlling the granularity of the sampling, thus affecting the final number of 
shards. It's especially useful when dealing with very large datasets where a 
lower sampling rate is preferred. The default value is 1000.                    
                                                                                
                                                                                
        |
 | common-options                             |         | No       | -          
     | Source plugin common parameters, please refer to [Source Common 
Options](../source-common-options.md) for details.                              
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
   |
+| string_split_mode                          | String  | No       | -          
     | When set to "charsetBased", enables charset-based string splitting 
algorithm. The algorithm assumes characters of partition_column are within 
ASCII range 32-126, which covers most character-based splitting scenarios.      
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
     |

Review Comment:
   1. The specific values for collate depend on the database support. For 
example, MySQL supports utf8_general_ci, utf8mb4_0900_ai_ci, etc.; PostgreSQL 
supports en_US.UTF-8 and fr_FR.UTF-8, etc.; SQL Server supports 
Latin1_General_BIN, etc.; Oracle supports SPANISH, BINARY_CI, etc.
   
   2. I have tested all the databases mentioned above, and they all work well. 
It's fair to say that most data sources support collation. If necessary, I will 
test more data sources.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to