Hisoka-X commented on code in PR #8820:
URL: https://github.com/apache/seatunnel/pull/8820#discussion_r2000094001


##########
docs/en/connector-v2/source/Jdbc.md:
##########
@@ -47,6 +47,7 @@ supports query SQL and can achieve projection effect.
 | password                                   | String  | No       | -          
     | password                                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                          |
 | query                                      | String  | No       | -          
     | Query statement                                                          
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                          |
 | compatible_mode                            | String  | No       | -          
     | The compatible mode of database, required when the database supports 
multiple compatible modes.<br/> For example, when using OceanBase database, you 
need to set it to 'mysql' or 'oracle'. <br/> when using starrocks, you need set 
it to `starrocks`                                                               
                                                                                
                                                                                
                                                                                
                                                                              |
+| dialect                                    | String  | No       | -          
     | The appointed dialect, if it does not exist, is still obtained according 
to the url, and the priority is higher than the url. <br/> For example,when 
using starrocks, you need set it to `starrocks`                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                              |

Review Comment:
   dialect list?



##########
docs/en/connector-v2/sink/Jdbc.md:
##########
@@ -88,6 +89,23 @@ For example, when using OceanBase database, you need to set 
it to 'mysql' or 'or
 
 Postgres 9.5 version or below,please set it to `postgresLow` to support cdc
 
+### dialect [string]
+
+The appointed dialect, if it does not exist, is still obtained according to 
the url, and the priority is higher than the url. For example,when using 
starrocks, you need set it to `starrocks`. Similarly, when using mysql, you 
need to set its value to `mysql`.
+
+#### Example optional

Review Comment:
   ```suggestion
   #### dialect list
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to