This is an automated email from the ASF dual-hosted git repository. jarvis pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push: new 7bd5865165 [hotfix][redis] fix npe cause by null host parameter (#8881) 7bd5865165 is described below commit 7bd58651653ab774ad88c203fb29d72be7df87eb Author: fcb-xiaobo <60566194+fcb-xia...@users.noreply.github.com> AuthorDate: Wed Mar 12 13:02:22 2025 +0800 [hotfix][redis] fix npe cause by null host parameter (#8881) --- docs/en/connector-v2/sink/Redis.md | 4 ++-- docs/en/connector-v2/source/Redis.md | 6 +++--- docs/zh/connector-v2/sink/Redis.md | 4 ++-- docs/zh/connector-v2/source/Redis.md | 4 ++-- .../connectors/seatunnel/redis/config/RedisBaseOptions.java | 2 +- .../connectors/seatunnel/redis/config/RedisParameters.java | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/en/connector-v2/sink/Redis.md b/docs/en/connector-v2/sink/Redis.md index 5b37720891..cddca528fb 100644 --- a/docs/en/connector-v2/sink/Redis.md +++ b/docs/en/connector-v2/sink/Redis.md @@ -14,8 +14,8 @@ Used to write data to Redis. | name | type | required | default value | |--------------------|---------|-----------------------|---------------| -| host | string | yes | - | -| port | int | yes | - | +| host | string | yes when mode=single | - | +| port | int | no | 6379 | | key | string | yes | - | | data_type | string | yes | - | | batch_size | int | no | 10 | diff --git a/docs/en/connector-v2/source/Redis.md b/docs/en/connector-v2/source/Redis.md index bd60830ba3..00e043aae8 100644 --- a/docs/en/connector-v2/source/Redis.md +++ b/docs/en/connector-v2/source/Redis.md @@ -18,9 +18,9 @@ Used to read data from Redis. ## Options | name | type | required | default value | -| ------------------- | ------ | --------------------- | ------------- | -| host | string | yes | - | -| port | int | yes | - | +| ------------------- | ------ |-----------------------| ------------- | +| host | string | yes when mode=single | - | +| port | int | no | 6379 | | keys | string | yes | - | | batch_size | int | yes | 10 | | data_type | string | yes | - | diff --git a/docs/zh/connector-v2/sink/Redis.md b/docs/zh/connector-v2/sink/Redis.md index d4bb13cd88..b21ddbc2ec 100644 --- a/docs/zh/connector-v2/sink/Redis.md +++ b/docs/zh/connector-v2/sink/Redis.md @@ -14,8 +14,8 @@ | name | type | required | default value | |--------------------|---------|-----------------------|---------------| -| host | string | yes | - | -| port | int | yes | - | +| host | string | `mode=single`时必须 | - | +| port | int | no | 6379 | | key | string | yes | - | | data_type | string | yes | - | | batch_size | int | no | 10 | diff --git a/docs/zh/connector-v2/source/Redis.md b/docs/zh/connector-v2/source/Redis.md index 8e30d87579..aeed710406 100644 --- a/docs/zh/connector-v2/source/Redis.md +++ b/docs/zh/connector-v2/source/Redis.md @@ -19,8 +19,8 @@ | 名称 | 类型 | 是否必须 | 默认值 | |---------------------|--------|--------------------|--------| -| host | string | 是 | - | -| port | int | 是 | - | +| host | string | `mode=single`时必须 | - | +| port | int | 否 | 6379 | | keys | string | 是 | - | | batch_size | int | 是 | 10 | | data_type | string | 是 | - | diff --git a/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisBaseOptions.java b/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisBaseOptions.java index 892d110cc2..7f398c9bcd 100644 --- a/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisBaseOptions.java +++ b/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisBaseOptions.java @@ -38,7 +38,7 @@ public class RedisBaseOptions { .withDescription("redis hostname or ip"); public static final Option<Integer> PORT = - Options.key("port").intType().noDefaultValue().withDescription("redis port"); + Options.key("port").intType().defaultValue(6379).withDescription("redis port"); public static final Option<String> AUTH = Options.key("auth") diff --git a/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java b/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java index 7758afacec..c9e4337d79 100644 --- a/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java +++ b/seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/config/RedisParameters.java @@ -46,7 +46,7 @@ import static org.apache.seatunnel.connectors.seatunnel.redis.exception.RedisErr @Slf4j public class RedisParameters implements Serializable { private String host; - private int port; + private Integer port; private String auth = ""; private int dbNum; private String user = "";