Hisoka-X commented on code in PR #8862:
URL: https://github.com/apache/seatunnel/pull/8862#discussion_r1976825538
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlanGenerator.java:
##########
@@ -274,15 +274,14 @@ private List<PhysicalVertex> getCommitterTask(
}
// if sinkAggregatedCommitter is empty, don't
create task.
if (sinkAggregatedCommitter.isPresent()) {
- long taskGroupID = idGenerator.getNextId();
- long taskTypeId = idGenerator.getNextId();
+ long taskGroupID =
taskGroupIdGenerator.getNextId();
TaskGroupLocation taskGroupLocation =
new TaskGroupLocation(
jobImmutableInformation.getJobId(),
pipelineIndex,
taskGroupID);
TaskLocation taskLocation =
- new TaskLocation(taskGroupLocation,
taskTypeId, 0);
+ new TaskLocation(taskGroupLocation, 1,
0);
Review Comment:
It's a little werid some index start with 0 but some index start with 1.
Let's all start with 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
