corgy-w commented on code in PR #8880:
URL: https://github.com/apache/seatunnel/pull/8880#discussion_r1976581878
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java:
##########
@@ -294,6 +297,8 @@ private static Object getJSQLParserDataTypeValue(Expression
expression) {
return ((TimeValue) expression).getValue();
} else if (expression instanceof TimestampValue) {
return ((TimestampValue) expression).getValue();
+ } else if (expression instanceof TimeValue) {
+ return ((TimeValue) expression).getValue();
Review Comment:
`expression instanceof TimeValue` repeated
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java:
##########
@@ -268,6 +268,9 @@ private static Object convertValueByPaimonDataType(
case DATE:
return DateTimeUtils.toInternal(
org.apache.seatunnel.common.utils.DateUtils.parse(strValue));
+ case TIME_WITHOUT_TIME_ZONE:
+ return DateTimeUtils.toInternal(
+
org.apache.seatunnel.common.utils.TimeUtils.parse(strValue));
Review Comment:
`org.apache.seatunnel.common.utils.` These two package prefixes do not seem
to be required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
