joyCurry30 commented on code in PR #8858: URL: https://github.com/apache/seatunnel/pull/8858#discussion_r1974707519
########## docs/en/connector-v2/sink/AmazonDynamoDB.md: ########## @@ -14,34 +14,38 @@ Write data to Amazon DynamoDB | Name | Type | Required | Default value | |-------------------|--------|----------|---------------| -| url | string | yes | - | -| region | string | yes | - | -| access_key_id | string | yes | - | -| secret_access_key | string | yes | - | +| url | string | no | - | +| region | string | no | - | +| access_key_id | string | no | - | +| secret_access_key | string | no | - | | table | string | yes | - | | batch_size | string | no | 25 | | common-options | | no | - | ### url [string] -The URL to write to Amazon DynamoDB. +The URL to write to Amazon DynamoDB. It will override the `endpoint` of AWS DynamoDB. Note: the `url` and `region` parameters can only be set one. When setting the url, the `region` parameter will be ignored. Review Comment: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/region-selection.html In the "Choose a specific endpoint" section of this document, you can see the "endpointOverride" will override the endpoint of region. Although the documentation example includes both the “endpoint” and “region” parameters, our testing shows that only the “endpoint” parameter takes effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
