Hisoka-X commented on code in PR #8825:
URL: https://github.com/apache/seatunnel/pull/8825#discussion_r1970828673


##########
docs/en/connector-v2/source/RocketMQ.md:
##########
@@ -218,3 +219,62 @@ sink {
 }
 ```
 
+### Specified timestamp Simple:
+
+> This is to specify a time to consume, and I dynamically sense the existence 
of a new partition every 1000 milliseconds to pull the consumption

Review Comment:
   Please update the description



##########
seatunnel-connectors-v2/connector-rocketmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rocketmq/config/ConsumerConfig.java:
##########
@@ -31,6 +31,15 @@ public class ConsumerConfig extends Config {
                     .withDescription(
                             "RocketMq topic name. If there are multiple 
topics, use , to split, for example: "
                                     + "\"tpc1,tpc2\".");
+
+    public static final Option<String> TAGS =
+            Options.key("tags")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "RocketMq tag name. If there are multiple tags, 
use , to split, for example: "

Review Comment:
   ```suggestion
                               "RocketMq tag name. If there are multiple tags, 
use `,` to split, for example: "
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to