Hisoka-X commented on code in PR #8774:
URL: https://github.com/apache/seatunnel/pull/8774#discussion_r1964965488
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java:
##########
@@ -84,7 +84,7 @@ public interface JdbcOptions {
Option<Integer> FETCH_SIZE =
Options.key("fetch_size")
.intType()
- .defaultValue(0)
+ .defaultValue(1024)
Review Comment:
Changing the default value may cause loss of optimization logic inside the
driver. It is better to keep it as 0 and let the driver decide the default
value itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
