Re: [PR] [Fix][Connector-V2] Fix possible data loss in certain scenarios of starrocks [seatunnel]

[via GitHub]

xiaochen-zhou commented on PR #8768:
URL: https://github.com/apache/seatunnel/pull/8768#issuecomment-2672117863

   I added a test case, `StarRocksIT#testStarRocksReadRowCount()`, to verify 
whether the number of rows written to the sink matches the number of rows read 
from the source in scenarios where `request_tablet_size` is less than the 
number of `BUCKETS`.
   
   When I set the table's buckets to 3:
   
   ```sql
   DISTRIBUTED BY HASH(`BIGINT_COL`) BUCKETS 3
   ```
   At the same time, when request_tablet_size is set to a value less than 3:
   
   
![image](https://github.com/user-attachments/assets/61df3efd-2557-4205-ac33-f72aa84a183e)
   
   The `StarRocksIT#testStarRocksReadRowCount()` test could not pass before the 
fix:
   
   
![image](https://github.com/user-attachments/assets/2ebf82c9-290b-4389-8fc2-24270ddc362a)
   
   In this case, the row count is 31, which is less than the expected 100.
   
   
![image](https://github.com/user-attachments/assets/5ac2b998-cfac-4b4e-b44f-547f1b7bd11f)
   
   After applying the fix, the StarRocksIT#testStarRocksReadRowCount() test now 
passes successfully:
   
   
![image](https://github.com/user-attachments/assets/3f5c34f6-2abe-42ce-945a-70f55125e92b)
   
   @hailin0 @Hisoka-X 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org