sohurdc commented on code in PR #8610:
URL: https://github.com/apache/seatunnel/pull/8610#discussion_r1944555398


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java:
##########
@@ -145,4 +145,6 @@ default Optional<Serializer<AggregatedCommitInfoT>> 
getAggregatedCommitInfoSeria
     default Optional<CatalogTable> getWriteCatalogTable() {
         return Optional.empty();
     }
+
+    default void close() {}

Review Comment:
   It is enabled, but there are still memory leaks in FileSystem$CACHE and 
HiveConf. I still have the problem of off-heap memory leak. I can't find the 
reason. I suspect it is related to the FileSystem not being closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to