Hisoka-X commented on code in PR #8276:
URL: https://github.com/apache/seatunnel/pull/8276#discussion_r1885456703
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -774,20 +784,24 @@ default boolean supportDefaultValue(BasicTypeDefine
columnDefine) {
/**
* whether quotes with default value
*
- * @param sqlType sql type of column
+ * @param columnDefine column define
* @return whether needs quotes with the type
*/
- default boolean needsQuotesWithDefaultValue(String sqlType) {
+ default boolean needsQuotesWithDefaultValue(BasicTypeDefine columnDefine) {
return false;
}
/**
* whether is special default value e.g. current_timestamp
*
* @param defaultValue default value of column
+ * @param sourceDialectName source dialect name
* @return whether is special default value e.g current_timestamp
*/
- default boolean isSpecialDefaultValue(Object defaultValue) {
+ default boolean isSpecialDefaultValue(Object defaultValue, String
sourceDialectName) {
+ if (DatabaseIdentifier.MYSQL.equals(sourceDialectName)) {
+ return DefaultValueUtils.isMysqlSpecialDefaultValue(defaultValue);
+ }
Review Comment:
@hailin0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
