Re: [PR] [improve] improve hazelcast joiner, lite node can't be election as master [seatunnel]

[via GitHub]

liunaijie commented on code in PR #8261:
URL: https://github.com/apache/seatunnel/pull/8261#discussion_r1883482166


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelNodeContext.java:
##########
@@ -45,15 +50,28 @@ public NodeExtension createNodeExtension(@NonNull Node 
node) {
 
     @Override
     public Joiner createJoiner(Node node) {
+
         JoinConfig join =
                 
getActiveMemberNetworkConfig(seaTunnelConfig.getHazelcastConfig()).getJoin();
         join.verify();
 
-        if (join.getTcpIpConfig().isEnabled()) {
+        // update for seatunnel, lite member can not become master node
+        if (join.getMulticastConfig().isEnabled() && node.multicastService != 
null) {
+            log.info("Using LiteNodeDropOutMulticast Multicast discovery");
+            return new LiteNodeDropOutMulticastJoiner(node);
+        } else if (join.getTcpIpConfig().isEnabled()) {
             log.info("Using LiteNodeDropOutTcpIpJoiner TCP/IP discovery");
             return new LiteNodeDropOutTcpIpJoiner(node);
+        } else if (node.getProperties().getBoolean(DISCOVERY_SPI_ENABLED)
+                || isAnyAliasedConfigEnabled(join)
+                || join.isAutoDetectionEnabled()) {
+            log.info("Using LiteNodeDropOutDiscoveryJoiner Discovery SPI");
+            return new LiteNodeDropOutDiscoveryJoiner(node);
         }
+        return null;

Review Comment:
   Has cover all cases. Same like original implement.
   
   
![image](https://github.com/user-attachments/assets/cf898f72-4546-43ad-a479-df215d70b95b)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org