Hisoka-X commented on code in PR #8237:
URL: https://github.com/apache/seatunnel/pull/8237#discussion_r1883341311
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/util/SchemaUtils.java:
##########
@@ -111,33 +116,53 @@ && columnExists(
public static void applySchemaChange(
Connection connection, TablePath tablePath,
AlterTableChangeColumnEvent event)
throws SQLException {
- StringBuilder sqlBuilder =
- new StringBuilder()
- .append("ALTER TABLE")
- .append(" ")
- .append(tablePath.getFullName())
+ ComparableVersion targetVersion = new
ComparableVersion(MIN_VERSION_TABLE_CHANGE_COLUMN);
+ ComparableVersion currentVersion;
+ try (Statement statement = connection.createStatement()) {
+ ResultSet resultSet = statement.executeQuery("SELECT
CURRENT_VERSION() as version");
Review Comment:
we should close ResultSet in try statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
