This is an automated email from the ASF dual-hosted git repository.

wuchunfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 430bbf62ac [Improve][Test] Enable some spark test case on jdk 11 
(#8238)
430bbf62ac is described below

commit 430bbf62ac4eef3d734adc6b697365df851eaeb6
Author: Jia Fan <fanjiaemi...@qq.com>
AuthorDate: Mon Dec 9 18:00:35 2024 +0800

    [Improve][Test] Enable some spark test case on jdk 11 (#8238)
---
 .../apache/seatunnel/core/starter/spark/SparkCommandArgsTest.java  | 7 -------
 .../core/starter/spark/multitable/MultiTableSinkTest.java          | 7 -------
 .../org/apache/seatunnel/translation/spark/sink/SparkSinkTest.java | 7 -------
 3 files changed, 21 deletions(-)

diff --git 
a/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/SparkCommandArgsTest.java
 
b/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/SparkCommandArgsTest.java
index da997e3355..213dc0179a 100644
--- 
a/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/SparkCommandArgsTest.java
+++ 
b/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/SparkCommandArgsTest.java
@@ -25,19 +25,12 @@ import 
org.apache.seatunnel.core.starter.spark.multitable.MultiTableSinkTest;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledOnJre;
-import org.junit.jupiter.api.condition.JRE;
 
 import java.io.FileNotFoundException;
 import java.net.URISyntaxException;
 
 import static org.apache.seatunnel.api.common.CommonOptions.PLUGIN_NAME;
 
-@DisabledOnJre(
-        value = JRE.JAVA_11,
-        disabledReason =
-                "We should update apache common lang3 version to 3.8 to avoid 
NPE, "
-                        + "see 
https://github.com/apache/commons-lang/commit/50ce8c44e1601acffa39f5568f0fc140aade0564";)
 public class SparkCommandArgsTest {
     @Test
     public void testExecuteClientCommandArgsWithPluginName()
diff --git 
a/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/multitable/MultiTableSinkTest.java
 
b/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/multitable/MultiTableSinkTest.java
index 61ed44515c..41b4285391 100644
--- 
a/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/multitable/MultiTableSinkTest.java
+++ 
b/seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/test/java/org/apache/seatunnel/core/starter/spark/multitable/MultiTableSinkTest.java
@@ -27,8 +27,6 @@ import 
org.apache.seatunnel.e2e.sink.inmemory.InMemorySinkWriter;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledOnJre;
-import org.junit.jupiter.api.condition.JRE;
 
 import lombok.extern.slf4j.Slf4j;
 
@@ -45,11 +43,6 @@ import java.util.List;
 public class MultiTableSinkTest {
 
     @Test
-    @DisabledOnJre(
-            value = JRE.JAVA_11,
-            disabledReason =
-                    "We should update apache common lang3 version to 3.8 to 
avoid NPE, "
-                            + "see 
https://github.com/apache/commons-lang/commit/50ce8c44e1601acffa39f5568f0fc140aade0564";)
     public void testMultiTableSink()
             throws FileNotFoundException, URISyntaxException, CommandException 
{
         String configurePath = "/config/fake_to_inmemory_multi_table.conf";
diff --git 
a/seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-3.3/src/test/java/org/apache/seatunnel/translation/spark/sink/SparkSinkTest.java
 
b/seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-3.3/src/test/java/org/apache/seatunnel/translation/spark/sink/SparkSinkTest.java
index 2e0d0f3f0d..44b5fe6e83 100644
--- 
a/seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-3.3/src/test/java/org/apache/seatunnel/translation/spark/sink/SparkSinkTest.java
+++ 
b/seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-3.3/src/test/java/org/apache/seatunnel/translation/spark/sink/SparkSinkTest.java
@@ -36,8 +36,6 @@ import org.apache.spark.sql.types.MapType;
 import org.apache.spark.sql.types.StructType;
 
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledOnJre;
-import org.junit.jupiter.api.condition.JRE;
 
 import java.math.BigDecimal;
 import java.sql.Timestamp;
@@ -60,11 +58,6 @@ import static 
org.apache.spark.sql.types.DataTypes.TimestampType;
 public class SparkSinkTest {
 
     @Test
-    @DisabledOnJre(
-            value = JRE.JAVA_11,
-            disabledReason =
-                    "We should update apache common lang3 version to 3.8 to 
avoid NPE, "
-                            + "see 
https://github.com/apache/commons-lang/commit/50ce8c44e1601acffa39f5568f0fc140aade0564";)
     public void testSparkSinkWriteDataWithCopy() {
         // We should make sure that the data is written to the sink with copy.
         SparkSession spark =

Reply via email to