liunaijie commented on code in PR #8241:
URL: https://github.com/apache/seatunnel/pull/8241#discussion_r1875451348
##########
config/seatunnel.yaml:
##########
@@ -25,6 +25,9 @@ seatunnel:
print-job-metrics-info-interval: 60
slot-service:
dynamic-slot: true
+ coordinator-service:
+ core-thread-num: 30
+ max-thread-num: 1000
Review Comment:
when add this parameter, it will limit the thread size.
now the default is int max, if we use a small value as the default value, it
maybe cause exception when user upgrade version.
so I suggest use int max as default value, and describe this feature in
document let user update it by self.
##########
config/seatunnel.yaml:
##########
@@ -25,6 +25,9 @@ seatunnel:
print-job-metrics-info-interval: 60
slot-service:
dynamic-slot: true
+ coordinator-service:
+ core-thread-num: 30
+ max-thread-num: 1000
Review Comment:
I see the default value is int max, we can remove `max-thread-num` config
from yaml, If user need change, they can update it by self.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
