dufeng1010 commented on code in PR #8237:
URL: https://github.com/apache/seatunnel/pull/8237#discussion_r1875403847


##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/util/SchemaUtils.java:
##########
@@ -138,6 +138,15 @@ public static void applySchemaChange(
         try (Statement statement = connection.createStatement()) {
             log.info("Executing change column SQL: " + changeColumnSQL);
             statement.execute(changeColumnSQL);
+        } catch (SQLException e) {
+            // from v3.3.2 onwards, StarRocks supports renaming columns
+            // if use previous starrocks version, program will be terminal
+            // suggest the sqlexception. programe will continue running
+            log.warn(
+                    "Executing change column SQL: {},  Error Message: {}",
+                    changeColumnSQL,
+                    e.getMessage());
+            e.printStackTrace();

Review Comment:
   yes, it did. some field data in the upstream cann't be synchronized to 
starrocks. 
   i suggest to write a note in the document that versions prior to starrocks 
3.3.2 do not support renaming columns, and renamed columns will not synchronize 
data. error messages will also be printed in the log.   Other functions are 
normal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to