Hisoka-X commented on code in PR #8221:
URL: https://github.com/apache/seatunnel/pull/8221#discussion_r1870910093
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/servlet/AllNodeLogServlet.java:
##########
@@ -66,7 +66,7 @@ protected void doGet(HttpServletRequest req,
HttpServletResponse resp)
FormatType formatType =
FormatType.fromString(req.getParameter("format"));
switch (formatType) {
case JSON:
- writeJson(resp, logService.allNodeLogFormatHtml(jobId));
+ writeJson(resp, logService.allNodeLogFormatJson(jobId));
Review Comment:
We missed add some test case in
https://github.com/apache/seatunnel/blob/06df51bcbbb3294f40ebb5607c70bc031c5175f8/seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/joblog/JobLogIT.java#L56.
Could you help to add test case @showfine ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
