Carl-Zhou-CN commented on code in PR #8029:
URL: https://github.com/apache/seatunnel/pull/8029#discussion_r1843551886
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java:
##########
@@ -111,6 +111,16 @@ public static List<CatalogTable> getCatalogTables(
return Collections.singletonList(catalogTable);
}
+ List<Map<String, Object>> schemaMaps =
+ readonlyConfig.get(TableSchemaOptions.TABLES_CONFIGS);
+ if (schemaMaps != null) {
+ if (schemaMaps.isEmpty()) {
+ throw new SeaTunnelException("tables_configs can not be
empty");
+ }
+ return schemaMaps.stream()
+ .map(map -> buildWithConfig(factoryId,
ReadonlyConfig.fromMap(map)))
+ .collect(Collectors.toList());
+ }
Review Comment:
This is a method marked as @Deprecated. Can it be moved elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
