Hisoka-X commented on code in PR #7529: URL: https://github.com/apache/seatunnel/pull/7529#discussion_r1843098510
########## docs/en/connector-v2/source/Clickhouse.md: ########## @@ -1,3 +1,4 @@ + Review Comment: ```suggestion ``` ########## docs/en/connector-v2/source/Clickhouse.md: ########## @@ -95,6 +96,49 @@ sink { } ``` +### Multi Table read Review Comment: Could you update zh doc too? Thanks. ########## seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceFactory.java: ########## @@ -62,65 +39,11 @@ public String factoryIdentifier() { return "Clickhouse"; } - @Override - public <T, SplitT extends SourceSplit, StateT extends Serializable> - TableSource<T, SplitT, StateT> createSource(TableSourceFactoryContext context) { Review Comment: why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org