Hisoka-X commented on code in PR #7665:
URL: https://github.com/apache/seatunnel/pull/7665#discussion_r1759719905
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-ftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/ftp/FtpFileIT.java:
##########
@@ -143,6 +153,70 @@ public void testFtpFileReadAndWrite(TestContainer
container)
helper.execute("/excel/fake_source_to_ftp_root_path_excel.conf");
}
+ @TestTemplate
+ @DisabledOnContainer(
+ value = {},
+ type = {EngineType.FLINK},
+ disabledReason =
+ "Fink test is multi-node, FtpFile connector will use
different containers for obtaining files")
Review Comment:
```suggestion
"Flink dosen't support multi-table at now")
```
##########
docs/en/connector-v2/sink/FtpFile.md:
##########
@@ -273,6 +287,33 @@ FtpFile {
```
+When our source end is multiple tables, and wants different expressions to
different directory, we can configure this way
+```bash
Review Comment:
```suggestion
```hocon
```
##########
docs/en/connector-v2/sink/FtpFile.md:
##########
@@ -83,7 +85,7 @@ The target ftp password is required
### path [string]
-The target dir path is required.
+The target dir path is required, you can inject the upstream CatalogTable into
the path by using: `${database_name}`, `${table_name}` and `${schema_name}`.
Review Comment:
```suggestion
The target dir path is required.
```
We have `Sink Parameter Placeholders` part to share this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
