corgy-w commented on code in PR #7595:
URL: https://github.com/apache/seatunnel/pull/7595#discussion_r1748835263
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/AbstractJdbcIT.java:
##########
@@ -496,6 +497,16 @@ public void testCatalogWithCatalogUtils() throws
SQLException, ClassNotFoundExce
.getFullName()
.equalsIgnoreCase(jdbcCase.getTablePathFullName()));
});
+ Collection<JdbcSourceTable> sourceTables = tables.values();
+ sourceTables.forEach(
+ sourceTable -> {
+ final String catalogName =
+
sourceTable.getCatalogTable().getTableId().getCatalogName();
+ if (this.catalog != null) {
+ Assertions.assertTrue(
+ StringUtils.equalsIgnoreCase(catalogName,
this.catalog.name()));
+ }
+ });
Review Comment:
See you made additions in this test, but this test filters the operation of
some types of databases through `jdbcCase.getTablePathFullName()`,I think you
could supply `tablePathFullName` in other type, or write another test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
