lightzhao commented on code in PR #7273:
URL: https://github.com/apache/seatunnel/pull/7273#discussion_r1706820700


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java:
##########
@@ -58,8 +61,7 @@ public void run() {
                         task.accept(consumer);
                     }
                 } catch (Exception e) {
-                    throw new KafkaConnectorException(
-                            KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, 
e);

Review Comment:
   
https://github.com/apache/seatunnel/blob/16eeb1c12323b462474ad23103de96c0060a4537/seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java#L71
   The exception is triggered by commit:
   
https://github.com/apache/seatunnel/blob/16eeb1c12323b462474ad23103de96c0060a4537/seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java#L289
   Poll will not throw an exception:
   
https://github.com/apache/seatunnel/blob/16eeb1c12323b462474ad23103de96c0060a4537/seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java#L147



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to