Hisoka-X commented on code in PR #7229:
URL: https://github.com/apache/seatunnel/pull/7229#discussion_r1681204962
##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/serialize/SeaTunnelRowSerializer.java:
##########
@@ -105,46 +79,40 @@ public String parseDeleteSign(RowKind rowKind) {
}
}
- public static Builder builder() {
- return new Builder();
- }
-
- /** Builder for RowDataSerializer. */
- public static class Builder {
- private SeaTunnelRowType seaTunnelRowType;
- private String type;
- private String fieldDelimiter;
- private boolean deletable;
-
- public Builder setType(String type) {
- this.type = type;
- return this;
- }
+ @Override
+ public void open() throws IOException {}
- public Builder setSeaTunnelRowType(SeaTunnelRowType seaTunnelRowType) {
- this.seaTunnelRowType = seaTunnelRowType;
- return this;
- }
+ @Override
+ public byte[] serialize(SeaTunnelRow seaTunnelRow) throws IOException {
- public Builder setFieldDelimiter(String fieldDelimiter) {
- this.fieldDelimiter = fieldDelimiter;
- return this;
- }
+ List<String> fieldNames =
Arrays.asList(seaTunnelRowType.getFieldNames());
+ List<SeaTunnelDataType<?>> fieldTypes =
Arrays.asList(seaTunnelRowType.getFieldTypes());
- public Builder enableDelete(boolean deletable) {
- this.deletable = deletable;
- return this;
+ if (enableDelete) {
+ SeaTunnelRow seaTunnelRowEnableDelete = seaTunnelRow.copy();
Review Comment:
reuse `parseDeleteSign`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
