hailin0 commented on code in PR #7158:
URL: https://github.com/apache/seatunnel/pull/7158#discussion_r1673382053


##########
docs/en/connector-v2/sink/Mivlus.md:
##########
@@ -0,0 +1,39 @@
+# Milvus
+
+> Milvus sink connector
+
+## Description
+
+Write data to Milvus or Zilliz Cloud
+
+## Key Features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [x] [exactly-once](../../concept/connector-v2-features.md)
+- [ ] [column projection](../../concept/connector-v2-features.md)
+
+## Sink Options
+
+|         Name         |  Type   | Required |           Default            |   
                     Description                        |
+|----------------------|---------|----------|------------------------------|-----------------------------------------------------------|
+| url                  | String  | Yes      | -                            | 
The URL to connect to Milvus or Zilliz Cloud.             |
+| token                | String  | Yes      | -                            | 
User:password                                             |
+| database             | String  | No       | -                            | 
Write data to which database, default is source database. |
+| schema_save_mode     | enum    | No       | CREATE_SCHEMA_WHEN_NOT_EXIST | 
Auto create table when table not exist.                   |
+| enable_auto_id       | boolean | No       | false                        | 
Primary key column enable autoId.                         |
+| enable_upsert        | boolean | No       | false                        | 
Upsert data not insert.                                   |
+| enable_dynamic_field | boolean | No       | true                         | 
Enable create table with dynamic field.                   |
+| batch_size           | int     | No       | 1000                         | 
Write batch size.                                         |
+

Review Comment:
   add data-type-mapping
   
   reference
   
https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/sink/Doris.md#data-type-mapping



##########
docs/en/connector-v2/source/Mivlus.md:
##########
@@ -0,0 +1,35 @@
+# Milvus
+
+> Milvus source connector
+
+## Description
+
+Read data from Milvus or Zilliz Cloud
+
+## Key Features
+
+- [x] [batch](../../concept/connector-v2-features.md)
+- [x] [exactly-once](../../concept/connector-v2-features.md)
+- [ ] [column projection](../../concept/connector-v2-features.md)
+
+## Source Options
+
+|    Name    |  Type  | Required | Default |                                   
     Description                                         |
+|------------|--------|----------|---------|--------------------------------------------------------------------------------------------|
+| url        | String | Yes      | -       | The URL to connect to Milvus or 
Zilliz Cloud.                                              |
+| token      | String | Yes      | -       | User:password                     
                                                         |
+| database   | String | Yes      | default | Read data from which database.    
                                                         |
+| collection | String | No       | -       | If set, will only read one 
collection, otherwise will read all collections under database. |
+
+## Task Example

Review Comment:
   add data-type-mapping
   
   reference
   
https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/MySQL-CDC.md#data-type-mapping



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to