Hisoka-X commented on code in PR #7148:
URL: https://github.com/apache/seatunnel/pull/7148#discussion_r1672178021
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/source/HbaseSourceReader.java:
##########
@@ -39,22 +40,21 @@
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Deque;
-import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Objects;
-import java.util.Set;
import java.util.concurrent.ConcurrentLinkedDeque;
+import java.util.stream.Collectors;
@Slf4j
public class HbaseSourceReader implements SourceReader<SeaTunnelRow,
HbaseSourceSplit> {
- private static final String ROW_KEY = "rowkey";
+ private final String ROW_KEY = "rowkey";
Review Comment:
Why remove static?
##########
docs/en/connector-v2/source/Hbase.md:
##########
@@ -17,75 +17,80 @@ Read data from Apache Hbase.
## Options
-| name | type | required | default value |
-|--------------------|--------|----------|---------------|
-| zookeeper_quorum | string | yes | - |
-| table | string | yes | - |
-| query_columns | list | yes | - |
-| schema | config | yes | - |
-| hbase_extra_config | string | no | - |
-| common-options | | no | - |
+| Name | Type | Required | Default |
+|--------------------|---------|----------|---------|
+| zookeeper_quorum | string | Yes | - |
+| table | string | Yes | - |
+| schema | config | Yes | - |
+| hbase_extra_config | string | No | - |
+| caching | int | No | -1 |
+| batch | int | No | -1 |
+| cache_blocks | boolean | No | false |
+| common-options | | No | - |
### zookeeper_quorum [string]
-The zookeeper cluster host of hbase, example:
"hadoop001:2181,hadoop002:2181,hadoop003:2181"
+The zookeeper quorum for Hbase cluster hosts, e.g.,
"hadoop001:2181,hadoop002:2181,hadoop003:2181".
### table [string]
-The table name you want to write, example: "seatunnel"
-
-### query_columns [list]
-
-The column name which you want to query in the table. If you want to query the
rowkey column, please set "rowkey" in query_columns.
-Other column format should be: columnFamily:columnName, example: ["rowkey",
"columnFamily1:column1", "columnFamily1:column1", "columnFamily2:column1"]
Review Comment:
Why remove this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
