Hisoka-X commented on code in PR #5745:
URL: https://github.com/apache/seatunnel/pull/5745#discussion_r1494155199
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/SeaTunnelContainer.java:
##########
@@ -228,6 +228,9 @@ private List<String> removeSystemThread(List<String>
beforeThreads, List<String>
|| s.contains(
"org.apache.hadoop.fs.FileSystem$Statistics$StatisticsDataReferenceCleaner")
|| s.startsWith("Log4j2-TF-")
+ ||
s.contains("java-sdk-http-connection-reaper")
+ || s.contains("Timer for 's3a-file-system'
metrics system")
+ || s.startsWith("MutableQuantiles-")
Review Comment:
please move it into
https://github.com/apache/seatunnel/pull/5745/files#diff-828bb95593582c2297e60ef9a6ced4733f251eef77389235d8c3b506dd0beb47L291
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ContainerUtil.java:
##########
@@ -251,6 +252,12 @@ public static List<TestContainer> discoverTestContainers()
{
}
}
+ public static List<TestContainer> discoverTestSpark3Containers() {
+ return discoverTestContainers().stream()
+ .filter(testContainer -> testContainer instanceof
Spark3Container)
+ .collect(Collectors.toList());
+ }
Review Comment:
please remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
