(seatunnel) branch dev updated: [Fix][Oracle-CDC] Fix invalid split key when no primary key (#6251)

[gaojun2048]

This is an automated email from the ASF dual-hosted git repository.

gaojun2048 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new b83c40a6f6 [Fix][Oracle-CDC] Fix invalid split key when no primary key 
(#6251)
b83c40a6f6 is described below

commit b83c40a6f6d82c381218d24405dfaddce89122fe
Author: hailin0 <wanghai...@apache.org>
AuthorDate: Wed Jan 24 10:05:06 2024 +0800

    [Fix][Oracle-CDC] Fix invalid split key when no primary key (#6251)
---
 .../oracle/source/eumerator/OracleChunkSplitter.java   | 18 ------------------
 .../connectors/seatunnel/cdc/oracle/OracleCDCIT.java   |  2 +-
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java
 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java
index aa3311149f..8500c0c055 100644
--- 
a/seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java
+++ 
b/seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java
@@ -33,7 +33,6 @@ import lombok.extern.slf4j.Slf4j;
 import oracle.sql.ROWID;
 
 import java.sql.SQLException;
-import java.sql.Types;
 
 /**
  * The {@code ChunkSplitter} used to split Oracle table into a set of chunks 
for JDBC data source.
@@ -104,21 +103,4 @@ public class OracleChunkSplitter extends 
AbstractJdbcSourceChunkSplitter {
             return ObjectUtils.compare(obj1, obj2);
         }
     }
-
-    @Override
-    protected Column getSplitColumn(
-            JdbcConnection jdbc, JdbcDataSourceDialect dialect, TableId 
tableId)
-            throws SQLException {
-        try {
-            Column splitColumn = super.getSplitColumn(jdbc, dialect, tableId);
-            if (splitColumn != null) {
-                return splitColumn;
-            }
-        } catch (SQLException e) {
-            log.info(
-                    "Failed to obtain the split key policy, the split key is 
changed to the default one",
-                    e);
-        }
-        return 
Column.editor().jdbcType(Types.VARCHAR).name(ROWID.class.getSimpleName()).create();
-    }
 }
diff --git 
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java
 
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java
index a71b82852b..ade8470aa0 100644
--- 
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java
+++ 
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java
@@ -272,7 +272,7 @@ public class OracleCDCIT extends TestSuiteBase implements 
TestResource {
             value = {},
             type = {EngineType.SPARK, EngineType.FLINK},
             disabledReason = "Currently SPARK and FLINK do not support multi 
table")
-    public void testMysqlCdcMultiTableE2e(TestContainer container)
+    public void testOracleCdcMultiTableE2e(TestContainer container)
             throws IOException, InterruptedException {
 
         clearTable(DATABASE, SOURCE_TABLE1);